Skip to content

feat: add GHCR support for container registry#48

Open
gabor-boros wants to merge 3 commits intoeduNEXT:mainfrom
open-craft:gabor/add-ghcr-support
Open

feat: add GHCR support for container registry#48
gabor-boros wants to merge 3 commits intoeduNEXT:mainfrom
open-craft:gabor/add-ghcr-support

Conversation

@gabor-boros
Copy link
Copy Markdown

This PR adds GHCR support for the container registry, so GitHub can be used over DockerHub or AWS ECR. Also, the PR sets the generated images as job outputs, so the images can be referenced in later steps if needed.

The later one is particularly useful when someone wants to build a pipeline where service build jobs are running parallel and the config.yml file should be updated at once.

@gabor-boros gabor-boros requested a review from a team as a code owner November 5, 2025 05:52
@felipemontoya
Copy link
Copy Markdown
Member

@magajh @DeimerM could you please take a look at this? I'll add it in the next sprint

@gabor-boros
Copy link
Copy Markdown
Author

@magajh / @DeimerM is there anything I could help with to move this forward?

@magajh magajh self-requested a review November 25, 2025 19:02
Copy link
Copy Markdown
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

Regarding the “Show image name for service” part, we’re planning to apply a fix in the upcoming sprint so that the image tag push doesn’t fail (in the dynamic tag case) when multiple builds are running or when there’s a push to the repository in the middle of a build. That said, the change you’re proposing here still feels very useful as a safeguard for edge cases where updating the tag in the repo fails for some reason and the user still needs to see which tag was generated

Comment thread .github/workflows/build.yml
Comment thread .github/workflows/build.yml Outdated
Signed-off-by: Gabor Boros <gabor@opencraft.com>
Signed-off-by: Gabor Boros <gabor@opencraft.com>
@gabor-boros gabor-boros force-pushed the gabor/add-ghcr-support branch from 91109cf to ab86fba Compare April 21, 2026 07:53
Signed-off-by: Gabor Boros <gabor@opencraft.com>
@gabor-boros
Copy link
Copy Markdown
Author

@magajh sorry, this was a "bit" delayed. I removed the image tag outputs as it is not used anymore and it makes no sense to contribute something that used by noone. Instead, I focused on the documentation and added a new section to the readme listing and describing the current registries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants