Open
Conversation
setenv is preferable because it doesn't carry the potential memory leak or null access if the launcher were to exec, for example. Note that we may want to prepend the release bin path rather than append? It would give more predictable behavior. The question is whether we want to allow the bin path to be overridden by a caller's environment or now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setenv is preferable because it doesn't carry the potential memory leak or null access if the launcher were to exec, for example.
Note that we may want to prepend the release bin path rather than append? It would give more predictable behavior. The question is whether we want to allow the bin path to be overridden by a caller's environment or now.