Set release variables as they appear in the release launcher#16
Open
adamwight wants to merge 1 commit intoelixir-desktop:masterfrom
Open
Set release variables as they appear in the release launcher#16adamwight wants to merge 1 commit intoelixir-desktop:masterfrom
adamwight wants to merge 1 commit intoelixir-desktop:masterfrom
Conversation
`mix release` creates a bin/ launcher for the application which sets up several environment variables. I've noticed that in some circumstances—currently unclear exactly when this is, maybe only if `runtime.exs` is used?—the Elixir config provider will try to assertively fetch these two variables from the environment. We can set the variables without hurting use cases which don't require them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mix releasecreates a bin/ launcher for the application which sets up several environment variables. I've noticed that in some circumstances—currently unclear exactly when this is, maybe only ifruntime.exsis used?—the Elixir config provider will try to assertively fetch these two variables from the environment.We can set the variables without hurting use cases which don't require them.