Skip to content

cmd/go: document go mod vendor omission of non-Go dirs#78605

Open
amirHdev wants to merge 1 commit intogolang:masterfrom
amirHdev:cmd-go-vendor-57529-doc
Open

cmd/go: document go mod vendor omission of non-Go dirs#78605
amirHdev wants to merge 1 commit intogolang:masterfrom
amirHdev:cmd-go-vendor-57529-doc

Conversation

@amirHdev
Copy link
Copy Markdown
Contributor

@amirHdev amirHdev commented Apr 9, 2026

Document that go mod vendor copies package source files and files matched by //go:embed patterns, not complete source trees.

This clarifies that directories without Go package files are omitted unless they are needed by an embed pattern.

Issue 57529 reported a surprising behavior where vendoring a dependency could omit non-Go subdirectories that are still needed by cgo includes. That behavior is current and intentional given how vendoring works today, but the command documentation did not say it clearly.

Fixes #57529

@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: c2f81be) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/764481.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@amirHdev amirHdev force-pushed the cmd-go-vendor-57529-doc branch from c2f81be to 6edc4a3 Compare April 9, 2026 12:59
@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: 6edc4a3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/764481.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/764481.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cmd/go: document that go mod vendor ignores directories that do not contain Go files

2 participants