cmd/go: document go mod vendor omission of non-Go dirs#78605
Open
amirHdev wants to merge 1 commit intogolang:masterfrom
Open
cmd/go: document go mod vendor omission of non-Go dirs#78605amirHdev wants to merge 1 commit intogolang:masterfrom
amirHdev wants to merge 1 commit intogolang:masterfrom
Conversation
Contributor
|
This PR (HEAD: c2f81be) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/764481. Important tips:
|
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
c2f81be to
6edc4a3
Compare
Contributor
|
This PR (HEAD: 6edc4a3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/764481. Important tips:
|
Contributor
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/764481. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that go mod vendor copies package source files and files matched by //go:embed patterns, not complete source trees.
This clarifies that directories without Go package files are omitted unless they are needed by an embed pattern.
Issue 57529 reported a surprising behavior where vendoring a dependency could omit non-Go subdirectories that are still needed by cgo includes. That behavior is current and intentional given how vendoring works today, but the command documentation did not say it clearly.
Fixes #57529