Make error handling in wrapped legacy map consistent with modern version.#1948
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Make error handling in wrapped legacy map consistent with modern version.#1948copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
…ion. The wrapped legacy implementation would use absl status return to propagate expected errors leading to inconsistencies in error handling depending on whether the underlying map was backed by a modern or legacy map. Update so that expected errors are cel::ErrorValue and unexpected errors (internal bug or client error) are returned as failed operations. Add Documentation for MapValue members. PiperOrigin-RevId: 900900524
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make error handling in wrapped legacy map consistent with modern version.
The wrapped legacy implementation would use absl status return to propagate expected errors leading to inconsistencies in
error handling depending on whether the underlying map was backed by a modern or legacy map. Update so that expected errors
are cel::ErrorValue and unexpected errors (internal bug or client error) are returned as failed operations.
Add Documentation for MapValue members.