feat: begin laying out things for go worker#5275
Draft
michaelkedar wants to merge 2 commits intogoogle:masterfrom
Hidden character warning
The head ref may contain hidden characters: "\ud83d\udc77\ud83d\ude45\ud83d\udc0d"
Draft
feat: begin laying out things for go worker#5275michaelkedar wants to merge 2 commits intogoogle:masterfrom
michaelkedar wants to merge 2 commits intogoogle:masterfrom
Conversation
michaelkedar
commented
Apr 22, 2026
| } | ||
|
|
||
| func (s *Subscriber) Run(ctx context.Context) error { | ||
| return s.PubSubSub.Receive(ctx, func(ctx context.Context, m *pubsub.Message) { |
Member
Author
There was a problem hiding this comment.
by they way, you can configure parallelism on this pubsub.Subscriber, so we wouldn't have to manually manage a worker pool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very much not complete, but think of this as a design doc without the doc part.
The basic idea is to have a bunch of Enrichers in charge of populating fields in the records as the worker currently does, but in a more concrete and modular pipeline.
I've Implemented the thing that adds the source link into database_specific as an example, but Enrichers will include version enumeration, PURL generated, etc.
Affected commit computation and enumeration will happen after the enricher pipeline, since it needs to return the list of commits that are not part of the OSV record.
I've made two separate structs for the pub/sub subscriber/parser and the actual vuln processing struct (the 'engine') which hopefully makes it less coupled to pub/sub.