ASP-2043: Add typed gRPC built-in retry support to GrpcChannelConfig#93
Merged
aaron-steinfeld merged 3 commits intohypertrace:mainfrom Apr 24, 2026
Merged
Conversation
kunalvaswani123
force-pushed
the
ASP-2043
branch
from
6b8b9a2 to
3672e14
Compare
kunalvaswani123
changed the title
kunalvaswani123
force-pushed
the
ASP-2043
branch
from
766944b to
a545450
Compare
…lt-in retry - Add optional serviceConfig field to GrpcChannelConfig - Wire defaultServiceConfig() + enableRetry() in GrpcChannelRegistry when serviceConfig is set - Add test verifying channels with different service configs are cached independently Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> AI-Session-Id: 75f3864c-dc2c-4e44-b4f3-b23c980f2ea6 AI-Tool: claude-code AI-Model: unknown
kunalvaswani123
force-pushed
the
ASP-2043
branch
from
a545450 to
4fe9c35
Compare
aaron-steinfeld
requested changes
Apr 24, 2026
…nfig and GrpcRetryPolicy Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> AI-Session-Id: 75f3864c-dc2c-4e44-b4f3-b23c980f2ea6 AI-Tool: claude-code AI-Model: unknown
kunalvaswani123
force-pushed
the
ASP-2043
branch
from
eea75b6 to
60d59ad
Compare
kunalvaswani123
changed the title
kunalvaswani123
force-pushed
the
ASP-2043
branch
from
60d59ad to
45a9491
Compare
…t-in, in-process retry test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> AI-Session-Id: 75f3864c-dc2c-4e44-b4f3-b23c980f2ea6 AI-Tool: claude-code AI-Model: unknown
kunalvaswani123
force-pushed
the
ASP-2043
branch
from
45a9491 to
9aa00a1
Compare
aaron-steinfeld
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GrpcRetryPolicy— typed retry config (maxAttempts, backoff, retryable status codes)GrpcServiceConfig— wrapsGrpcRetryPolicy, owns conversion to gRPC service config mapserviceConfig: GrpcServiceConfigandenableRetry: booleantoGrpcChannelConfigas independent opt-insGrpcChannelRegistry.configureAndBuildChannel()— no retry assumed from service config aloneTest plan
GrpcChannelRegistryRetryTest— starts a real in-process gRPC server that fails twice withUNAVAILABLE, succeeds on the 3rd attempt, and asserts the server was hit 3 times from a single client call🤖 Generated with Claude Code