feat: add shared exception hierarchy for Kubeflow SDK#459
feat: add shared exception hierarchy for Kubeflow SDK#459Goku2099 wants to merge 2 commits intokubeflow:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
ab83a73 to
c9075dc
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces a shared exception hierarchy under kubeflow.common to standardize error types across Kubeflow SDK clients, aligning with Issue #458’s goal of more precise, catchable domain errors.
Changes:
- Added
kubeflow.common.exceptionsdefiningKubeflowErrorplus a minimal set of domain-specific exceptions. - Added
kubeflow.common.__init__exports so exceptions can be imported fromkubeflow.common.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
kubeflow/common/exceptions.py |
Adds the shared exception class hierarchy (base + initial set). |
kubeflow/common/__init__.py |
Re-exports the exception types as part of the kubeflow.common public API. |
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
|
I have made some updates to the PR based on the initial feedback and kept the scope focused on introducing the shared exception hierarchy. Would appreciate your thoughts on the approach whenever you get a chance. |
Introduce a shared exception module (kubeflow.common.exceptions) with a base KubeflowError and a minimal set of specific exceptions.
This lays the foundation for consistent and precise error handling across SDK clients. Migration of existing clients will be done in follow-up PRs.
#458