Skip to content

feat: add shared exception hierarchy for Kubeflow SDK#459

Open
Goku2099 wants to merge 2 commits intokubeflow:mainfrom
Goku2099:feat/shared-exceptions
Open

feat: add shared exception hierarchy for Kubeflow SDK#459
Goku2099 wants to merge 2 commits intokubeflow:mainfrom
Goku2099:feat/shared-exceptions

Conversation

@Goku2099
Copy link
Copy Markdown

Introduce a shared exception module (kubeflow.common.exceptions) with a base KubeflowError and a minimal set of specific exceptions.
This lays the foundation for consistent and precise error handling across SDK clients. Migration of existing clients will be done in follow-up PRs.

#458

Copilot AI review requested due to automatic review settings April 14, 2026 18:07
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown
Contributor

🎉 Welcome to the Kubeflow SDK! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
  • Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
@Goku2099 Goku2099 force-pushed the feat/shared-exceptions branch from ab83a73 to c9075dc Compare April 14, 2026 18:08
@Goku2099 Goku2099 changed the title Add shared exception hierarchy for Kubeflow SDK feat: dd shared exception hierarchy for Kubeflow SDK Apr 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a shared exception hierarchy under kubeflow.common to standardize error types across Kubeflow SDK clients, aligning with Issue #458’s goal of more precise, catchable domain errors.

Changes:

  • Added kubeflow.common.exceptions defining KubeflowError plus a minimal set of domain-specific exceptions.
  • Added kubeflow.common.__init__ exports so exceptions can be imported from kubeflow.common.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
kubeflow/common/exceptions.py Adds the shared exception class hierarchy (base + initial set).
kubeflow/common/__init__.py Re-exports the exception types as part of the kubeflow.common public API.

Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
@Goku2099
Copy link
Copy Markdown
Author

cc @tariq-hasan @Shekharrajak

I have made some updates to the PR based on the initial feedback and kept the scope focused on introducing the shared exception hierarchy.

Would appreciate your thoughts on the approach whenever you get a chance.

@Goku2099 Goku2099 changed the title feat: dd shared exception hierarchy for Kubeflow SDK feat: add shared exception hierarchy for Kubeflow SDK Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants