Open
Conversation
Author
Contributor
|
Looks good to me. That failing test has been there before, no worries. There's a merge conflict – please resolve it and we're good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
glib-main-loopthroughlivekitwhile keeping it enabled by default for desktop-oriented consumersLK_HEADLESS=1handling inwebrtc-sys/build.rsto skip Linux desktop capturer sources, GLib/GIO probing, and X11 desktop-capture linkageglib-main-loopexplicitly so example behavior remains desktop-friendlyWhy
On Linux,
libwebrtcenablesglib-main-loopby default andlivekitinherited that behavior transitively. That made it impossible to build an intentionally headless Linux configuration without pulling in the GLib desktop path. This change preserves the existing default behavior while making the headless path explicit and supported.Headless Linux requires both pieces:
LK_HEADLESS=1changes the Linux native build path inwebrtc-sys--no-default-features -F tokiodisables the default desktop-orientedglib-main-loopfeature in the Rust dependency graphIn other words,
LK_HEADLESS=1by itself is not intended to change the default feature selection forlivekit.Validation
cargo build -p livekitLK_HEADLESS=1 cargo build -p livekit --no-default-features -F tokiocargo tree -p livekit -i glibshowsglibin the default buildLK_HEADLESS=1 cargo tree -p livekit --no-default-features -F tokio -i glibshowsglibabsent from the graph