Revert "lkl: Implement lkl_printf and lkl_bug internally"#627
Open
tavip wants to merge 1 commit intolkl:masterfrom
Open
Revert "lkl: Implement lkl_printf and lkl_bug internally"#627tavip wants to merge 1 commit intolkl:masterfrom
tavip wants to merge 1 commit intolkl:masterfrom
Conversation
This reverts commit 486afba. lkl_printf is called before Linux is initialized in several instances and this use-case is the main reason for this API's existence. Unfortunately, and suprisingly, the Linux vsnprintf uses WARN* macros which will prints information about the CPU, current process, stack trace etc. and some of this information does require Linux to be initialized. Signed-off-by: Octavian Purdila <tavip@google.com>
Member
Author
|
@lrh2000 If we really want to keep this we need to add a new Kconfig option and disable WARN_ON when that is selected. I want to avoid this as it adds maintenance effort to us. As mention in the original thread adding support via host_ops for your environment is the canonical way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 486afba.
lkl_printf is called before Linux is initialized in several instances and this use-case is the main reason for this API's existence. Unfortunately, and suprisingly, the Linux vsnprintf uses WARN* macros which will prints information about the CPU, current process, stack trace etc. and some of this information does require Linux to be initialized.