Conversation
This is for Xiao S3 and a normal Wio SX1262 for Xiao shield.
|
My 2¢ input as someone who also is running a Xiao S3 with the WIO shield is; I like this and you beat me to opening a PR. But instead of adding it as a new variant, why not add it as a sub variant of the already existing Xiao S3? (see Xiao C6 for example) The Xiao that is already supported is a Xiao S3 with a populated B2B connector that doesn't use the D pins. They both still use WIO-SX1262 shields, this proposal just uses the v1.0 version without the B2B connector. I think the naming would be more clear if the new board is named |
|
So you want this variant as Xiao_S3_WIO_v1 in the current Xiao_S3_Wio? |
|
That naming just makes more sense to me and combining keeps more code from having to be repeated. However, this is ultimately your pull request and I am just a random person giving feedback, not a member of the MeshCore development team. |
@Sodium-Hydrogen It is a valid and may be a better idea. Let me see and try your approach in a few days. |
This is for Xiao S3 and a normal Wio SX1262 for Xiao shield.
Tested works fine (repeater and BLE companion) for two PowerSaving realeases.
PS: This is not a Xiao S3 Wio combo. The pin mappings are different (especially the mapping to DIO1).