Fix validate_scope rejecting scopes when client scope is None#2461
Open
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Fix validate_scope rejecting scopes when client scope is None#2461Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
When OAuthClientMetadata.scope is None (no scopes registered), validate_scope() was converting it to an empty list, causing all requested scopes to be rejected with InvalidScopeError. Now treats None as "no restrictions" and allows any requested scope through. Fixes modelcontextprotocol#2216
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAuthClientMetadata.validate_scope()incorrectly treatedscope=None(no registered scopes) as an empty allowed list, rejecting all requested scopes withInvalidScopeErrorself.scope is Noneto treat it as "no restrictions", allowing any requested scope throughvalidate_scopecovering the None case, valid subsets, exact matches, and invalid scope rejectionFixes #2216