fix(teams): accept username in edit member endpoint#5852
Merged
aecsocket merged 7 commits intomodrinth:mainfrom Apr 21, 2026
Merged
fix(teams): accept username in edit member endpoint#5852aecsocket merged 7 commits intomodrinth:mainfrom
aecsocket merged 7 commits intomodrinth:mainfrom
Conversation
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Sychic
force-pushed
the
fix/edit-teams-username
branch
from
7ca62ac to
6b7a9f5
Compare
aecsocket
requested changes
Apr 19, 2026
Comment on lines
+703
to
+708
| .ok_or_else(|| { | ||
| ApiError::InvalidInput( | ||
| "The user specified does not exist".to_string(), | ||
| ) | ||
| })? | ||
| .id; |
Contributor
There was a problem hiding this comment.
Should use .wrap_request_err() from crate::util::error::Context
Suggested change
| .ok_or_else(|| { | |
| ApiError::InvalidInput( | |
| "The user specified does not exist".to_string(), | |
| ) | |
| })? | |
| .id; | |
| .wrap_request_err("specified user does not exist")? | |
| .id; |
Sychic
force-pushed
the
fix/edit-teams-username
branch
from
6b7a9f5 to
1a83de2
Compare
aecsocket
approved these changes
Apr 21, 2026
| let user_id = ids.1.into(); | ||
|
|
||
| let user_id = DBUser::get(&ids.1, &**pool, &redis) | ||
| .await? |
Contributor
There was a problem hiding this comment.
nit: database ops should have a .wrap_internal_err("failed to fetch ...")
| ) | ||
| })?; | ||
| let team_association = DBTeam::get_association(id, &**pool) | ||
| .await? |
Contributor
There was a problem hiding this comment.
nit: database ops should have a .wrap_internal_err("failed to fetch ...")
| .await?; | ||
| let edit_member_db = | ||
| DBTeamMember::get_from_user_id_pending(id, user_id, &**pool) | ||
| .await? |
Contributor
There was a problem hiding this comment.
nit: database ops should have a .wrap_internal_err("failed to fetch ...")
auto-merge was automatically disabled
April 21, 2026 13:07
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, all inputs to the id/username argument were treated as ids regardless of whether they were or not. Now the input is resolved to a user to obtain a user id before proceeding.
Closes #2568