PYTHON-5778 Add unit tests for ocsp_support.py to increase coverage#2763
Draft
aclark4life wants to merge 2 commits intomongodb:masterfrom
Draft
PYTHON-5778 Add unit tests for ocsp_support.py to increase coverage#2763aclark4life wants to merge 2 commits intomongodb:masterfrom
aclark4life wants to merge 2 commits intomongodb:masterfrom
Conversation
Adds 62 unit tests covering all major functions and branches in pymongo/ocsp_support.py, bringing coverage from 57.64% to ~99%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5778
Changes in this PR
57.64% to ~99%
_get_certs_by_key_hash, _get_certs_by_name, _build_ocsp_request, _verify_response_signature, _verify_response, _get_ocsp_response, and _ocsp_callback
Test Plan
Checklist
Checklist for Author
Checklist for Reviewer