fix: ARenderer TypeError when href is undefined#32
Conversation
Fixes TypeError on `href.lenght` when href is undefined - tests `typeof href` is string before reading its length `useNormalizedUrl` can return `undefined` if it fails to parse absolute an url (see: normalizeResourceLocator.ts) > `[TypeError: Cannot read property 'length' of undefined]`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 140 140
Lines 2083 2084 +1
Branches 633 634 +1
=======================================
+ Hits 2055 2056 +1
Misses 27 27
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @arieloO, thanks for the contribution! |
- see fix: ARenderer TypeError when href is undefined (2c6f82a)
|
LGTM, let's wait for @jsamr to give the final approve |
As for me, it could go out even this week |
Fixes TypeError on
href.lengthwhen href is undefinedtypeof hrefis string before reading its lengthuseNormalizedUrlcan returnundefinedif it fails to parse absolute an url (see: normalizeResourceLocator.ts)