Skip to content

chore(deps): change pinning#654

Merged
bmuenzenmeyer merged 2 commits intomainfrom
pinning!
Apr 22, 2026
Merged

chore(deps): change pinning#654
bmuenzenmeyer merged 2 commits intomainfrom
pinning!

Conversation

@avivkeller
Copy link
Copy Markdown
Member

cc @ovflowd

Changes the dependency pinning per our docs. Rolldown was changed to be an exact dependency, as each release candidate may contain breaking changes.

Copilot AI review requested due to automatic review settings March 7, 2026 19:23
@avivkeller avivkeller requested a review from a team as a code owner March 7, 2026 19:23
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Apr 22, 2026 1:54am

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.95%. Comparing base (364fad2) to head (85a7baf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   77.95%   77.95%           
=======================================
  Files         159      159           
  Lines       14055    14055           
  Branches     1152     1152           
=======================================
  Hits        10957    10957           
  Misses       3093     3093           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 7, 2026

orama-db Generator

File Base Head Diff
orama-db.json 8.37 MB 8.37 MB -1.00 B (-0.00%)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates dependency version pinning to align with the project’s desired semver strategy, with a specific focus on making rolldown an exact version to avoid RC breakage leaking in via ranges.

Changes:

  • Convert several devDependencies from caret ranges (^) to pinned versions (exact and ~ patch ranges).
  • Pin rolldown to an exact release-candidate version (1.0.0-rc.6) in both manifest and shrinkwrap.
  • Regenerate npm-shrinkwrap.json to reflect the updated specifiers.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Updates dev dependency ranges (mostly pinned) and pins rolldown exactly.
npm-shrinkwrap.json Keeps shrinkwrap aligned with package.json changes and updates lock metadata accordingly.
Files not reviewed (1)
  • npm-shrinkwrap.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I totally agree with this approach of exact pinning, given this repo has demonstrated up until this point that it isn't really needed, but happy to approve, given this is what our current policy states. I agree with pinning rolldown specifically though.

Comment thread package.json
Copy link
Copy Markdown
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM although I feel some runtime dependencies could be more stricter.

@avivkeller
Copy link
Copy Markdown
Member Author

I'm going to open a dedicated issue to discuss how/what pinning rules should apply to this repo, since there's not 100% consensus here.

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Mar 8, 2026

I'm going to open a dedicated issue to discuss how/what pinning rules should apply to this repo, since there's not 100% consensus here.

While there's no consensus or we don't reach consensus the previously agreed rules apply fyi.

@avivkeller
Copy link
Copy Markdown
Member Author

Not necessarily, no. Those pinning guides are for the website, which this is not, so they don't really apply here, unless we make them, hence a dedicated issue.

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Apr 16, 2026

@avivkeller feel free to rebase, please. Remember the current dependency pinning agreement stands.

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 22, 2026

PR Summary

Low Risk
Low risk because changes are limited to dependency version ranges/lockfile updates, with no runtime logic changes; main impact is altered install/upgrade behavior.

Overview
Updates package.json dependency version ranges to follow the project’s pinning guidance, including switching rolldown to an exact 1.0.0-rc.12 to avoid accidental breaking changes between release candidates.

Regenerates package-lock.json to reflect the new constraints.

Reviewed by Cursor Bugbot for commit 85a7baf. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1bfc4b6. Configure here.

Comment thread package-lock.json
Comment thread package-lock.json
@bmuenzenmeyer
Copy link
Copy Markdown
Contributor

did the rebase - think the pinning stands as-is for now.

@bmuenzenmeyer
Copy link
Copy Markdown
Contributor

i'm going to merge so we dont drift again - @avivkeller please cut another issue if you like or havent yet

@bmuenzenmeyer bmuenzenmeyer merged commit f1c1c9c into main Apr 22, 2026
23 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the pinning! branch April 22, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants