Open
Conversation
jatinderjit
commented
Apr 18, 2026
| (if ($exclude | is-not-empty) {[cmd not like (quote '%' $exclude '%')]}) | ||
| (if not $all {[cwd = (quote $env.PWD)]}) | ||
| ] | ||
| orderBy: [[start desc]] |
Contributor
Author
There was a problem hiding this comment.
No code change here. Just moved it down for a consistent order (from > select > where > groupBy > orderBy > limit).
fdncred
reviewed
Apr 18, 2026
| --before (-b): duration | ||
| --dir (-d) | ||
| --path(-p): list<string@"nu-complete history dir"> | ||
| --path(-p): list<directory> |
Contributor
There was a problem hiding this comment.
why is this changed from 'nu-complete history dir'? it probably shouldn't be a type but it looks like it's intended to provid completions with --path
Contributor
Author
There was a problem hiding this comment.
I see a syntax error for this. I'm guessing this isn't supported.
I couldn't find a way to support autocomplete for lists. I could think of two alternatives:
- The cop out: support only a single path
- Use spread operator
...path: string@"nu-complete history dir".- It kind-of works, but has issues.
numis a positional argument, and has to be populated first. Probably it would need to be changed to a flagged param. - We'd like to hide already selected paths from "nu-complete history dir". We'd need to use context, but I couldn't figure out how it'd handle paths with spaces.
- It kind-of works, but has issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two errors:
list<string@"nu-complete history dir">flatten_fieldsexpects lists of strings. Wrapfromandlimitin lists, since they are singular elements