Add Manage Domains API and Nylas service account request signing#466
Merged
Add Manage Domains API and Nylas service account request signing#466
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
- Coverage 98.90% 97.51% -1.40%
==========================================
Files 52 57 +5
Lines 2293 2579 +286
==========================================
+ Hits 2268 2515 +247
- Misses 25 64 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sourcesoft
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Summary
/v3/admin/domainsviaClient.domains, with models innylas.models.domainsand methods: list, create, find, update, delete,get_info, andverify.ServiceAccountSignerinnylas.handler.service_accountand an optionalsignerargument on eachDomainsmethod to setX-Nylas-Kid,X-Nylas-Nonce,X-Nylas-Timestamp, andX-Nylas-Signature, using canonical JSON for request bodies where required.cryptographydependency and extendsHttpClient._executewith optionalserialized_json_bodyso signed payloads match the bytes sent on the wire.client.domains; updatesCHANGELOG.md(Unreleased).