feat: update content libraries API to use events from openedx-core [FC-0117]#38397
feat: update content libraries API to use events from openedx-core [FC-0117]#38397bradenmacdonald wants to merge 2 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
d8b2f5a to
999c392
Compare
999c392 to
bdfd169
Compare
Description
With openedx/openedx-core#543, openedx-core now emits events when changes happen within a Learning Package.
This PR updates the content libraries code and search code accordingly. The main benefit is that the search index now stays up to date regardless of which APIs are used. We don't need to "wrap" some low-level APIs in high-level APIs just to add events.
Note: The "Library Collections" code was already working fine because it used Django signals to watch for changes to the Collection-PublishableEntity many-to-many relationship, but it shouldn't have been so aware of the internals of openedx_content.
Supporting information
See openedx/openedx-core#462
Testing instructions
TODO
Deadline
Verawood
Other information
Depends on openedx/openedx-core#543 . But at the moment, you'll also have to revert the changes from Kyle's latest PRs on openedx-core
main, because edx-platform isn't yet compatible with them.