Remove author filtering for GitLab commit statuses#27
Open
majamassarini wants to merge 1 commit intopackit:mainfrom
Open
Remove author filtering for GitLab commit statuses#27majamassarini wants to merge 1 commit intopackit:mainfrom
majamassarini wants to merge 1 commit intopackit:mainfrom
Conversation
The previous implementation filtered GitLab commit statuses by author, expecting all statuses to be created by the Packit service account. However, GitLab CI pipeline statuses are authored by the commit author or project owner, not by external service accounts. Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
lbarcziova
approved these changes
Apr 20, 2026
| len(all_statuses), | ||
| ) | ||
|
|
||
| filtered_statuses = [status for status in all_statuses if self._check_status_author(status)] |
Member
There was a problem hiding this comment.
do we still need the _check_status_author method?
| len(filtered_statuses), | ||
| # GitLab pipeline statuses may not have the service account as author | ||
| # Only filter if we're looking for external commit statuses | ||
| # For now, accept all statuses to avoid filtering out GitLab CI pipelines |
Member
There was a problem hiding this comment.
for now - is there some plan here on how we should change the behaviour?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation filtered GitLab commit statuses by author, expecting all statuses to be created by the Packit service account. However, GitLab CI pipeline statuses are authored by the commit author or project owner, not by external service accounts.
Assisted-By: Claude Sonnet 4.5 noreply@anthropic.com