Draft
Conversation
kateeselius
reviewed
Apr 13, 2026
Contributor
kateeselius
left a comment
kateeselius
left a comment
There was a problem hiding this comment.
Also, you should add your amazing new fact to the enum list! https://github.com/snyk/snyk-docker-plugin/blob/main/components/common.yaml#L17
| } | ||
|
|
||
| export interface ProvenanceAttestationsFact { | ||
| type: "provenanceAttestations"; |
Contributor
There was a problem hiding this comment.
You will also need to add this to the enum here: https://github.com/snyk/snyk-docker-plugin/blob/main/components/common.yaml#L17
| `platform=${JSON.stringify(descriptor.platform)}, annotations=${JSON.stringify(descriptor.annotations)}`, | ||
| ); | ||
|
|
||
| const isAttestationManifest = |
Contributor
There was a problem hiding this comment.
is this just for provenance attestation? Are there other types that could end up with unknown architecture and "attestation-manifest" annotation?
| const attestations: ProvenanceAttestation[] = []; | ||
|
|
||
| debug( | ||
| `[provenance-poc] Scanning ${metadata.mainIndexFile!.manifests.length} descriptors in image index`, |
Contributor
There was a problem hiding this comment.
would mainIndexFile ever be undefined?
| `[provenance-poc] Attestation manifest content: ${JSON.stringify(nestedManifest, null, 2)}`, | ||
| ); | ||
|
|
||
| const attestationManifest = nestedManifest as OciArchiveManifest; |
Contributor
There was a problem hiding this comment.
Would malformed attestations be an issue here if they can't be casted to OciArchiveManifest?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions