refactor: remove no-op path validation#1201
Draft
rrama wants to merge 1 commit intorefactor/IDE-1786_folder-config-refactoringfrom
Draft
refactor: remove no-op path validation#1201rrama wants to merge 1 commit intorefactor/IDE-1786_folder-config-refactoringfrom
rrama wants to merge 1 commit intorefactor/IDE-1786_folder-config-refactoringfrom
Conversation
This has allowed removing a lot of error paths. Including `BatchUpdateFolderConfigs` which does nothing but log. `enrichFromGit` also did not need to return the `FolderConfig` it took in.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This has allowed removing a lot of error paths.
Including
BatchUpdateFolderConfigswhich does nothing but log.enrichFromGitalso did not need to return theFolderConfigit took in.Checklist
make generate)make lint-fix)