migrated avoid non null assertion rule and tests#230
Merged
Islam-Shaaban-Ibrahim merged 3 commits intoanalysis_server_migrationfrom Apr 16, 2026
Merged
migrated avoid non null assertion rule and tests#230Islam-Shaaban-Ibrahim merged 3 commits intoanalysis_server_migrationfrom
Islam-Shaaban-Ibrahim merged 3 commits intoanalysis_server_migrationfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the AvoidNonNullAssertionRule to extend AnalysisRule and introduces a visitor-based implementation for detecting non-null assertions. It also adds a new test suite for the rule. The review identifies a critical issue in the visitor where a lack of type promotion would lead to a compilation error when checking for Map types. There is also a suggestion to use more robust methods for identifying lint locations in tests instead of hardcoded offsets.
solid-vovabeloded
requested changes
Apr 16, 2026
Collaborator
solid-vovabeloded
left a comment
solid-vovabeloded
left a comment
There was a problem hiding this comment.
Overall, that looks pretty good. Just a few minor suggestions here.
solid-vovabeloded
approved these changes
Apr 16, 2026
Islam-Shaaban-Ibrahim
merged commit 87f0bd5
into
analysis_server_migration
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.