feat(codegen/go): support emit_pointers_for_null_types for nullable enums#4386
Open
winens wants to merge 2 commits intosqlc-dev:mainfrom
Open
feat(codegen/go): support emit_pointers_for_null_types for nullable enums#4386winens wants to merge 2 commits intosqlc-dev:mainfrom
winens wants to merge 2 commits intosqlc-dev:mainfrom
Conversation
…nums When emit_pointers_for_null_types is enabled, nullable enum columns now generate *EnumType pointers instead of NullEnumType wrapper structs. Previously, this setting only affected built-in types (sql.NullString -> *string), leaving enum types unaffected. Closes sqlc-dev#3276
…y files Use schema.sql and query.sql as separate files instead of a shared sql/ directory, matching the pattern used by other enum tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emit_pointers_for_null_typesto nullable enum columns — generates*EnumTypepointers instead ofNullEnumTypewrapper structsCloses #3276
Test plan
emit_pointers_for_null_typestests pass (no regressions)emit_pointers_for_null_types_enum/postgresql/pgx/v5— verifies*Sizepointer, noNullSizestructemit_pointers_for_null_types_enum/mysql— verifies*UsersShirtSizepointer, noNullUsersShirtSizestructfilterUnusedStructsupdated to handle pointer-prefixed enum types (found via code review)