Skip to content

fix(vector): Use relative path to patchable checked out source #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickLarsenNZ wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(vector): Use relative path to patchable checked out source #1471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b9ee68
fix(vector): Use relative path to patchable checked out source
NickLarsenNZ Apr 17, 2026
610146e
chore: Update changelog
NickLarsenNZ Apr 17, 2026
9f69cd5
Merge branch 'main' into fix/vector-sbom-copy
NickLarsenNZ Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@ All notable changes to this project will be documented in this file.

- trino: Backport fix for wrong deletes in Delta Lake ([#1453]).
- opensearch: Scope CycloneDX SBOM to shipped components only, eliminating false positive CVEs from unshipped plugins ([#1452]).
- vector: Look for SBOM in correct location ([#1471]).

[#1446]: https://github.com/stackabletech/docker-images/pull/1446
[#1452]: https://github.com/stackabletech/docker-images/pull/1452
[#1453]: https://github.com/stackabletech/docker-images/pull/1453
[#1454]: https://github.com/stackabletech/docker-images/pull/1454
[#1463]: https://github.com/stackabletech/docker-images/pull/1463
[#1466]: https://github.com/stackabletech/docker-images/pull/1466
[#1471]: https://github.com/stackabletech/docker-images/pull/1471

## [26.3.0] - 2026-03-16

Expand Down
4 changes: 3 additions & 1 deletion vector/copy_artifacts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@
cp "$1" /app

# And now try to find a BOM file named like the binary + _bin.cdx.xml and copy it over as well if it exists
# Using `patchable with --images-repo-root=src` makes the path `/stackable/src/vector/patchable-work/worktree/0.52.0`
# assuming WORKDIR was `/stackable`.
base=$(basename "$1")
find /src/ -type f -name "${base}_bin.cdx.xml" -exec cp {} /app \;
find ./src/ -type f -name "${base}_bin.cdx.xml" -exec cp {} /app \;
Copy link
Copy Markdown
Member

@dervoeti dervoeti Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
find ./src/ -type f -name "${base}_bin.cdx.xml" -exec cp {} /app \;
find . -maxdepth 1 -type f -name "${base}_bin.cdx.xml" -exec cp {} /app \;

Copy link
Copy Markdown
Member Author

@NickLarsenNZ NickLarsenNZ Apr 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if you tested it or not, but I now don't have time (due to other tasks) so I would go with what I have since it worked (it is gated by the exact match for ${base}_bin.cdx.xml).

I'm happy to come back and fix it if you see an issue - just not sure if this was more stylistic or an actual problem you discovered.

Loading