Skip to content

feat: Git sync - add first class support for CAs#903

Merged
adwk67 merged 19 commits intomainfrom
feat/gitsync-ca-support
Apr 20, 2026
Merged

feat: Git sync - add first class support for CAs#903
adwk67 merged 19 commits intomainfrom
feat/gitsync-ca-support

Conversation

@adwk67
Copy link
Copy Markdown
Member

@adwk67 adwk67 commented Feb 23, 2026

Description

Fixes stackabletech/issues#820

--- PASS: kuttl (377.22s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/custom-components-git-sync_nifi-2.7.2_zookeeper-latest-3.9.4_openshift-false (185.79s)
        --- PASS: kuttl/harness/custom-components-git-sync_nifi-1.28.1_zookeeper-latest-3.9.4_openshift-false (263.59s)
        --- PASS: kuttl/harness/custom-components-git-sync_nifi-2.6.0_zookeeper-latest-3.9.4_openshift-false (190.37s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 marked this pull request as ready for review April 8, 2026 14:28
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Apr 10, 2026
Copy link
Copy Markdown
Member Author

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B. Block this until #921 has been merged. Done

@adwk67
Copy link
Copy Markdown
Member Author

adwk67 commented Apr 17, 2026

Checked on Openshift:

--- PASS: kuttl (1607.81s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_v2_nifi-v2-2.7.2_use-zookeeper-manager-true_zookeeper-3.9.4_openshift-true_listener-class-external-unstable (163.03s)
        --- PASS: kuttl/harness/ldap_nifi-2.7.2_zookeeper-latest-3.9.4_ldap-use-tls-true_openshift-true (170.40s)
        --- PASS: kuttl/harness/oidc-opa_nifi-2.7.2_zookeeper-latest-3.9.4_opa-l-1.12.3_oidc-use-tls-true_openshift-true (266.34s)
        --- PASS: kuttl/harness/custom-components-git-sync_nifi-2.7.2_zookeeper-latest-3.9.4_openshift-true (182.06s)
        --- PASS: kuttl/harness/iceberg-hive_nifi-iceberg-hive-2.6.0_zookeeper-latest-3.9.4_opa-l-1.12.3_hdfs-l-3.4.2_hive-l-4.2.0_trino-l-477_krb5-1.21.1_iceberg-use-kerberos-true_kerberos-realm-PROD.MYCORP_openshift-true (652.62s)
        --- PASS: kuttl/harness/cluster_operation_nifi-latest-2.7.2_openshift-true (82.90s)
        --- PASS: kuttl/harness/smoke_v1_nifi-v1-1.28.1_zookeeper-3.9.4_openshift-true_listener-class-external-unstable (340.79s)
        --- PASS: kuttl/harness/resources_nifi-2.7.2_zookeeper-latest-3.9.4_openshift-true (66.55s)
        --- PASS: kuttl/harness/orphaned_resources_nifi-2.7.2_zookeeper-latest-3.9.4_openshift-true (56.90s)
        --- PASS: kuttl/harness/external-access_nifi-2.7.2_zookeeper-latest-3.9.4_openshift-true (86.27s)
        --- PASS: kuttl/harness/logging_nifi-2.7.2_zookeeper-latest-3.9.4_openshift-true (87.36s)
        --- PASS: kuttl/harness/iceberg-rest_nifi-iceberg-rest-2.7.2_hive-l-4.2.0_trino-l-477_openshift-true (364.04s)
        --- PASS: kuttl/harness/upgrade_nifi_old-1.28.1_nifi_new-2.7.2_zookeeper-latest-3.9.4_openshift-true (347.81s)
PASS

@razvan razvan self-requested a review April 20, 2026 07:09
@razvan razvan moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 20, 2026
razvan
razvan previously approved these changes Apr 20, 2026
Copy link
Copy Markdown
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. one small suggestion for improved readability imo.

Comment thread docs/modules/nifi/pages/usage_guide/custom-components.adoc Outdated
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Copy link
Copy Markdown
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@adwk67 adwk67 added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit 69f825d Apr 20, 2026
12 checks passed
@adwk67 adwk67 deleted the feat/gitsync-ca-support branch April 20, 2026 08:19
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

Git sync: add first class support for CAs

3 participants