Open
Conversation
Techassi
force-pushed
the
ci/template-publish-to-quay.io
branch
from
0c6b4cf to
ee1f794
Compare
Techassi
force-pushed
the
ci/template-publish-to-quay.io
branch
from
ee1f794 to
b738ac0
Compare
Techassi
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
NickLarsenNZ
requested changes
Apr 20, 2026
Member
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Just need to remove the comments
| uses: stackabletech/actions/publish-image@ac6f1d3b87f68826b9a5838d13864ef8e88dcf40 # v0.14.0 | ||
| with: | ||
| image-registry-uri: quay.io | ||
| image-registry-username: stackable+robot_sdp_github_action_build # Doesn't exist yet |
Member
There was a problem hiding this comment.
Don't forget to create this
Suggested change
| image-registry-username: stackable+robot_sdp_github_action_build # Doesn't exist yet | |
| image-registry-username: stackable+robot_sdp_github_action_build |
| with: | ||
| image-registry-uri: quay.io | ||
| image-registry-username: stackable+robot_sdp_github_action_build # Doesn't exist yet | ||
| image-registry-password: ${{ secrets.QUAY_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }} # Doesn't exist yet |
Member
There was a problem hiding this comment.
Suggested change
| image-registry-password: ${{ secrets.QUAY_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }} # Doesn't exist yet | |
| image-registry-password: ${{ secrets.QUAY_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }} |
| uses: stackabletech/actions/publish-image-index-manifest@ac6f1d3b87f68826b9a5838d13864ef8e88dcf40 # v0.14.0 | ||
| with: | ||
| image-registry-uri: quay.io | ||
| image-registry-username: stackable+robot_sdp_github_action_build # Doesn't exist yet |
Member
There was a problem hiding this comment.
Suggested change
| image-registry-username: stackable+robot_sdp_github_action_build # Doesn't exist yet | |
| image-registry-username: stackable+robot_sdp_github_action_build |
| with: | ||
| image-registry-uri: quay.io | ||
| image-registry-username: stackable+robot_sdp_github_action_build # Doesn't exist yet | ||
| image-registry-password: ${{ secrets.QUAY_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }} # Doesn't exist yet |
Member
There was a problem hiding this comment.
Suggested change
| image-registry-password: ${{ secrets.QUAY_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }} # Doesn't exist yet | |
| image-registry-password: ${{ secrets.QUAY_ROBOT_SDP_GITHUB_ACTION_BUILD_SECRET }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #583 to be merged first.Part of stackabletech/issues#716, based on stackabletech/airflow-operator#773.