Skip to content

test: Enable hot reloading in password files#868

Merged
siegfriedweber merged 9 commits intomainfrom
fix/hot-reloading
Apr 20, 2026
Merged

test: Enable hot reloading in password files#868
siegfriedweber merged 9 commits intomainfrom
fix/hot-reloading

Conversation

@siegfriedweber
Copy link
Copy Markdown
Member

@siegfriedweber siegfriedweber commented Mar 23, 2026

Description

Re-enable hot reloading in password files

Part of #834

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber siegfriedweber self-assigned this Mar 23, 2026
@siegfriedweber siegfriedweber added release-note Denotes a PR that will be considered when it comes time to generate release notes. scheduled-for/26.7.0 labels Mar 31, 2026
@siegfriedweber siegfriedweber marked this pull request as ready for review April 13, 2026 13:19
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Apr 15, 2026
@siegfriedweber
Copy link
Copy Markdown
Member Author

Release notes

Platform fixes

Trino

  • In the last release, hot-reloading of password file Secrets did not work anymore because a change to the Secret triggered a restart of the pods. With this release, the password file Secrets are excluded from the restarter controller and hot-reloading is supported again.

Copy link
Copy Markdown
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor comments.

Comment thread rust/operator-binary/src/authentication/password/file.rs
Comment thread rust/operator-binary/src/authentication/mod.rs Outdated
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 20, 2026
@siegfriedweber siegfriedweber requested a review from Techassi April 20, 2026 11:32
@siegfriedweber siegfriedweber added this pull request to the merge queue Apr 20, 2026
@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Apr 20, 2026
Merged via the queue into main with commit ebe7226 Apr 20, 2026
12 checks passed
@siegfriedweber siegfriedweber deleted the fix/hot-reloading branch April 20, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. scheduled-for/26.7.0

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants