Skip to content

feat(auth): Check for valid urls#1373

Merged
rubenhoenle merged 5 commits intomainfrom
feature/check-for-valid-urls
Apr 20, 2026
Merged

feat(auth): Check for valid urls#1373
rubenhoenle merged 5 commits intomainfrom
feature/check-for-valid-urls

Conversation

@Manuelvaas
Copy link
Copy Markdown
Contributor

Description

relates to STACKITCLI-340

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Manuelvaas Manuelvaas requested a review from a team as a code owner April 20, 2026 17:27
rubenhoenle
rubenhoenle previously approved these changes Apr 20, 2026
@rubenhoenle rubenhoenle force-pushed the feature/check-for-valid-urls branch from 13cb70c to 898a287 Compare April 20, 2026 17:43
@rubenhoenle rubenhoenle merged commit 00f524f into main Apr 20, 2026
3 checks passed
@rubenhoenle rubenhoenle deleted the feature/check-for-valid-urls branch April 20, 2026 17:49
@github-actions
Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/pkg/auth 55.45% (-0.20%) 👎
github.com/stackitcloud/stackit-cli/internal/pkg/utils 62.50% (+1.11%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/pkg/auth/user_login.go 0.00% (ø) 165 (+2) 0 165 (+2)
github.com/stackitcloud/stackit-cli/internal/pkg/auth/utils.go 57.63% (-0.86%) 59 (+6) 34 (+3) 25 (+3) 👎
github.com/stackitcloud/stackit-cli/internal/pkg/utils/utils.go 61.97% (+1.68%) 71 (+3) 44 (+3) 27 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/pkg/auth/utils_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/utils/utils_test.go

j1n-o9r pushed a commit to j1n-o9r/stackit-cli that referenced this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants