Add CODEOWNERS entry for temporalio/contrib#1467
Conversation
| # @temporalio/sdk will be requested for review when | ||
| # someone opens a pull request. | ||
| * @temporalio/sdk | ||
| /temporalio/contrib/ @temporalio/ai-sdk |
There was a problem hiding this comment.
Does this change the owner, or add additional owners? I don't have a problem with ai-sdk being notified, but it isn't the only owner of all the code there.
There was a problem hiding this comment.
Good question. From https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners:
If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.
There was a problem hiding this comment.
Then I don't think we want to do this.
There was a problem hiding this comment.
IIRC, the correct way to do this is (space alignment is totally optional):
* @temporalio/sdk
/temporalio/contrib/ @temporalio/ai-sdk @temporalio/sdk
There was a problem hiding this comment.
As we discussed, we'll want ownership to be:
- defined on a per-contrib-subdirectory basis
- to include
@temporalio/sdkas coowners, to ensure we can handle repo-wide/structural concerns.
So that would give something like this:
* @temporalio/sdk
/temporalio/contrib/plugin1 @temporalio/ai-sdk @temporalio/sdk
/temporalio/contrib/plugin2 @temporalio/ai-sdk @temporalio/sdk
/temporalio/contrib/plugin3 @temporalio/ai-sdk @temporalio/sdk
@tconley1428 might have other requirements to add.
Allow GitHub notifications to work for the AI SDK team