chore(ci): install protoc when building gems#425
Open
chris-olszewski wants to merge 9 commits intomainfrom
Open
chore(ci): install protoc when building gems#425chris-olszewski wants to merge 9 commits intomainfrom
chris-olszewski wants to merge 9 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Ensure correct protoc version is installed when we build gems for release. For source releases this is straightforward, for our cross-compiled gems we need to customize the docker image used to ensure it has
protocinstalled.Why?
In my excitement for #414, I forgot that Gems only get build on
mainso I didn't catch that these jobs were failing.Checklist
Closes N/A
How was this tested:
This PR initially also configured the Gem builds to happen on PRs as well as main: here is an example run of the gems building correctly.
N/A