Skip to content

Error page graph: for a time bucket don't fill zeros for a version with no errors #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-aitken merged 1 commit into from
Apr 17, 2026
+6 −1
Merged

Error page graph: for a time bucket don't fill zeros for a version with no errors #3402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/webapp/app/presenters/v3/ErrorGroupPresenter.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,15 @@ export class ErrorGroupPresenter extends BasePresenter {

const sortedVersions = sortVersionsDescending([...versionSet]);

// Build the data for the graph
// For each time bucket, if a value exists for a version set the value (don't add zeros)
const data = buckets.map((epoch) => {
const point: Record<string, number | Date> = { date: new Date(epoch * 1000) };
for (const version of sortedVersions) {
point[version] = byBucketVersion.get(`${epoch}:${version}`) ?? 0;
const versionValue = byBucketVersion.get(`${epoch}:${version}`);
if (versionValue) {
point[version] = versionValue;
}
Comment thread
matt-aitken marked this conversation as resolved.
}
return point;
});
Expand Down
Loading