[pull] master from ruby:master#950
Merged
pull[bot] merged 5 commits intoturkdevops:masterfrom Apr 20, 2026
Merged
Conversation
These functions may return -2 to indicate an error according to the manual [1]. This can also be confirmed when looking at the code as it may call into i2d_X509_NAME() which can fail [2]. In such cases, the failure is reinterpreted as a "less than" comparison and the error is not reported, potentially leading to wrong results in userland code. [1] https://manpages.opensuse.org/Tumbleweed/openssl-3-doc/X509_NAME_cmp.33ssl.en.html [2] https://github.com/openssl/openssl/blob/f023662d1bde1fcb7fecf976b25a45afd55734b8/crypto/x509/x509_cmp.c#L269-L271 ruby/openssl@08e5547b85
This function may return 0 on error [1]. [1] https://manpages.debian.org/stretch/libssl-doc/X509_set_serialNumber.3ssl.en.html ruby/openssl@c6caa4f1c1
This function actually returns a value <=0 on error, but it is not documented as such. Example from OpenSSL code [1] and implementation [2] indicate as such. [1] https://github.com/openssl/openssl/blob/4b8ddae690d6449005e474bfdfe73106d4d6c5ea/crypto/pkcs7/pk7_lib.c#L578 [2] https://github.com/openssl/openssl/blob/4b8ddae690d6449005e474bfdfe73106d4d6c5ea/crypto/pkcs7/pk7_lib.c#L625 ruby/openssl@e70a63fabe
This can technically fail because it internally performs allocations. Also confirmed by the man page [1]. [1] (among other functions on this page) https://docs.openssl.org/3.5/man3/BIO_get_ex_new_index ruby/openssl@c0de3f5c83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )