Conversation
|
Looks like we want to invert defaults here where the cast by default is name based from talking to @gatesn |
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will improve performance by 32.81%
Performance Changes
Comparing Footnotes
|
Signed-off-by: Robert Kruszewski <github@robertk.io>
|
Ok, I will add a cast registry |
|
@AdamGS I have dug through datafusion issues. The top level one is apache/datafusion#17330 where what Datafusion really wants is to remove I will make a pluggable cast |
|
I will have to redo this with deeper changes. Will close this and open a new pr #7588 is the first step we need for a real solution |
In order to handle full generality of casts we need to distinguish between
casting fields by name and by position. The positional casts are useful for non
sql systems where names are just metadata and the order of values matters.
However, in order to integrate with sql systesm we need by names casts as well.
It's not possible to handle them without any indication from the user which
behaviour they care about
fix #6900
Signed-off-by: Robert Kruszewski github@robertk.io