Prunning expressions can reference rowcount #7589
Open
robert3005 wants to merge 4 commits intodevelopfrom
Open
Prunning expressions can reference rowcount #7589robert3005 wants to merge 4 commits intodevelopfrom
robert3005 wants to merge 4 commits intodevelopfrom
Conversation
robert3005
commented
Apr 22, 2026
robert3005
commented
Apr 22, 2026
Merging this PR will improve performance by 31.9%
Performance Changes
Comparing |
Contributor
Author
|
I have tried making it an expression. The problem you run into is that this expression isn't constant so you can't rewrite it into literal but also that expression cannot be inferred from the existing arrays properties |
Contributor
Author
|
Ok, this is good to go now, a lot more code than I'd wish but at least it's pure array rewrite |
This lets us effectively prune expressions like IsNotNull Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
commented
Apr 23, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Comment on lines
47
to
52
| pub struct ZoneMap { | ||
| // The struct array backing the zone map | ||
| array: StructArray, | ||
| // The statistics that are included in the table. | ||
| stats: Arc<[Stat]>, | ||
| } |
Contributor
There was a problem hiding this comment.
its odd a zonemap doesn't know its row len?
Contributor
Author
There was a problem hiding this comment.
I think the layout knows. We can plumb that through that's a good point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us effectively prune expressions like IsNotNull
fix #7187
Signed-off-by: Robert Kruszewski github@robertk.io