Allow configuring session-wide vortex options in DF#7604
Open
Allow configuring session-wide vortex options in DF#7604
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
added
changelog/feature
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
a10y
reviewed
Apr 23, 2026
| format_options: &std::collections::HashMap<String, String>, | ||
| ) -> DFResult<Arc<dyn FileFormat>> { | ||
| let mut opts = self.options.clone().unwrap_or_default(); | ||
| let mut opts = state |
Contributor
There was a problem hiding this comment.
shouldn't we delete the options field from the format factory if we always pull it out of the state now?
Contributor
Author
There was a problem hiding this comment.
I don't think you do, you have two code paths here.
- The one enabled by this PR - User sets a session-level config, which propagates down to new tables.
- User executes a DDL statement like
CREATE EXTERNAL TABLE t ... OPTIONS (my_vortex_conf=7); which goes through the factory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR shits the DF config to use the
ExtensionAPI which seems like the right thing? It keeps all the other nice behaviors will allowing users to configure session wide things (either through SQL or directly).