Loading spinner in attach ephemeral IP modal#3200
Merged
david-crespo merged 3 commits intomainfrom Apr 24, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
force-pushed
the
ephemeral-ip-error-handling
branch
from
fca47bf to
6a2ecef
Compare
Collaborator
Author
|
@charliepark I pulled in your |
charliepark
approved these changes
Apr 24, 2026
Contributor
charliepark
left a comment
charliepark
left a comment
There was a problem hiding this comment.
Looks good, and I like the sentinel approach to testing. Certainly easier than mucking around with blocking resources in developer tools.
Collaborator
Author
|
I had to add it to the CLAUDE.md because Claude was happy to write an interceptor in the test that makes the response an error and I didn’t like that. It’s not terrible, but I didn’t like how it has to match by URL path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3197. Turns out we were using a bespoke modal + form thing instead of our dedicated
ModalFormcomponent that handles the loading state in the button. Turns out there are a bunch of modal forms that aren't usingModalFormlike they probably should. I'll fix the other ones in another PR.