Use the ModalForm component for Ephemeral IPs#3201
Closed
charliepark wants to merge 1 commit intomainfrom
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Welp. Looks like this is a dupe of #3200 |
| /** Must be provided with a reason describing why it's disabled */ | ||
| submitDisabled?: boolean | ||
| /** When set, disables the submit button and shows this string as the disabled reason */ | ||
| submitDisabled?: string |
Collaborator
There was a problem hiding this comment.
I don't have this change in mine but I think it might be the right idea. Disabling the button without a message feels kinda junky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, our Attach Ephemeral IP modal is using a custom modal component, when we can use the ModalForm component to bring in the benefits of a loading spinner and an error message, like we have on the Attach Floating IP modal.
This builds on #3192, which moved the messages from toasts into the modals.
The spinner is a little high on the button, but that's just because it's hard to capture the moment, and the spinner drops in on the button.
Closes #3197